cell-ontology icon indicating copy to clipboard operation
cell-ontology copied to clipboard

NTR L2 marginal neuron and Lamp5 Lhx6 neuron

Open AvolaAmg opened this issue 1 year ago • 10 comments

Fixes #2346 #2345

In Lamp5 Lhx6 neuron, I wanted to add in the logical definition and (expresses some 'LIM/homeobox 6') but it does not seem to be available in the database.

AvolaAmg avatar Apr 23 '24 09:04 AvolaAmg

#gogoeditdiff

aleixpuigb avatar May 07 '24 10:05 aleixpuigb

Your branch is 1 commit/s behind, please update your branch.

github-actions[bot] avatar May 07 '24 10:05 github-actions[bot]

#gogoeditdiff

dosumis avatar May 07 '24 15:05 dosumis

#gogoeditdiff

anitacaron avatar May 08 '24 14:05 anitacaron

#gogoeditdiff

aleixpuigb avatar May 08 '24 14:05 aleixpuigb

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-05-08/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-05-08/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

L2 marginal neuron http://purl.obolibrary.org/obo/CL_4042012

Added

Lamp5 Lhx6 neuron http://purl.obolibrary.org/obo/CL_4042013

Added

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

L2 marginal neuron http://purl.obolibrary.org/obo/CL_4042012

Added

Lamp5 Lhx6 neuron http://purl.obolibrary.org/obo/CL_4042013

Added

github-actions[bot] avatar May 08 '24 14:05 github-actions[bot]

Much easier to review with diffs working again.

Couple of concerns:

  1. This still feels like an uneasy mix of classic def and t-type. It's classified under lamp5 GABAergic cortical interneuron so inherits the assertion about lamp5 expression from there. The text includes Lhx6 expression as a differentium, but this is not reflected in the axioms. It's possible that neither of these is 100% safe for all subtypes. It feels somewhat arbitrary to have axioms asserting expression of one but not the other.
  2. The reference data used as differentium is human specific, but the class is not.

So - I think needs a bit more discussion.

dosumis avatar May 09 '24 10:05 dosumis

Some notes based Jorstad as a reference:

Lamp5 & Lamp5 Lhx6 t-types are disjoint:

image

LAMP5 consistently marks both & all subclusters (crossArea)

image image

Lhx6 consistently is a very clean marker of the Lhx6 cluster - there is only subcluster (i.e. one cell set, 2 annotations)

image

dosumis avatar May 09 '24 10:05 dosumis

Based on the above the, marker assertions appear safe (although we don't know about other species - would be good to look at mice). The bigger problem is t-type disjointness vs classical def subsumption.

dosumis avatar May 09 '24 10:05 dosumis

Note - to refer to Lhx6, we need to import from PRO

dosumis avatar May 23 '24 14:05 dosumis

#gogoeditdiff

dosumis avatar May 23 '24 14:05 dosumis

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR editor will be allowed to proceed with merging without explicit approval, should they wish to do so.

github-actions[bot] avatar Jun 24 '24 01:06 github-actions[bot]