cell-ontology icon indicating copy to clipboard operation
cell-ontology copied to clipboard

Add hillock cells of urethra and prostate

Open lubianat opened this issue 3 years ago • 9 comments

Relates to #1134

lubianat avatar Oct 13 '22 14:10 lubianat

Side comment: to automatically close the issue you linked, GitHub recognises the words "fixes", and "closes". 🙂

anitacaron avatar Oct 13 '22 14:10 anitacaron

@lubianat, if you'd like to try resolving the conflict, there are notes here: https://obophenotype.github.io/cell-ontology/resolving_merge_conflicts/

If there are pending questions before merging, let me know and I'll try to assist.

ghost avatar Oct 14 '22 15:10 ghost

Hi, @lubianat, checking in if assistance is needed to merge this PR.

ghost avatar Oct 19 '22 09:10 ghost

Thank you, @bvarner-ebi ! No assistance needed so far, I work on CL on Thursdays, so there probably will be updates by then. Cheers!

lubianat avatar Oct 19 '22 12:10 lubianat

@lubianat, FYI, I am planning a CL release this coming Friday.

ghost avatar Oct 25 '22 13:10 ghost

Couldn't do it last week, sorry, and this week I'm away. If anyone wants to do it faster, its ok for me.

Em ter., 25 de out. de 2022 08:07, bvarner-ebi @.***> escreveu:

@lubianat https://github.com/lubianat, FYI, I am planning a CL release this coming Friday.

— Reply to this email directly, view it on GitHub https://github.com/obophenotype/cell-ontology/pull/1711#issuecomment-1290523991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4NC7Y2W3EURN6V2G7VC7DWE7LPZANCNFSM6AAAAAAREKEBOY . You are receiving this because you were mentioned.Message ID: @.***>

lubianat avatar Oct 25 '22 20:10 lubianat

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-10-26/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-10-26/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_0017010 http://purl.obolibrary.org/obo/CL_0017010

Added

CL_0017011 http://purl.obolibrary.org/obo/CL_0017011

Added

github-actions[bot] avatar Oct 26 '22 12:10 github-actions[bot]

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_0017010 http://purl.obolibrary.org/obo/CL_0017010

Added

CL_0017011 http://purl.obolibrary.org/obo/CL_0017011

Added

github-actions[bot] avatar Oct 26 '22 12:10 github-actions[bot]