Add new bone length from to DOSDP pattern template
If applied, this commit will fix #73.
is there a way to change the label if needed? If so, what column would that be?
is there a way to change the label if needed? If so, what column would that be?
Yes, you can override the automatic label. It think it is the defined_class_name column in your .tsv.
great, can we add that to the template?
@rays22 why is this failing?
@rays22 what is left to do on this?
this is why we have the property chain for copo
On Wed, Sep 7, 2022 at 4:02 AM Nico Matentzoglu @.***> wrote:
@.**** commented on this pull request.
In src/patterns/dosdp-patterns/length_from_to.yaml https://github.com/obophenotype/bio-attribute-ontology/pull/75#discussion_r964704709 :
- your_comments
+def:
- text: "The length of a %s from %s to %s."
- vars:
- element
- from
- to
- annotations:
- annotationProperty: xref
value: def_ref+equivalentTo:
- text: "'length' and ('characteristic_of' some ('part_of' some %s))"
if part of a bone [e.g., 'distalmost' ('part of' some humerus)]
NOTE: Everything is part of itself.
The only relevant consequence is that the length of the whole would not be classified under this term! It would be a sibling.
— Reply to this email directly, view it on GitHub https://github.com/obophenotype/bio-attribute-ontology/pull/75#discussion_r964704709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOOAPMCIN4FN773JVPLV5BY3ZANCNFSM5RAE3ROQ . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>
Of course the issue here is that the whole exactly should not classify under this, only the parts!
@rays22 I updated the pattern. Can we meet to test the pattern?