bio-attribute-ontology icon indicating copy to clipboard operation
bio-attribute-ontology copied to clipboard
verified publisher icon obophenotype

Create ratio_location.yaml

Open ar-ibrahim opened this issue 2 years ago • 2 comments

  • issue #272
  • Rough (very) draft of 'ratio' pattern, including proposed name of pattern.
  • To discuss in monthly OBA meeting (July 21st 2023)

ar-ibrahim avatar Jul 20 '23 14:07 ar-ibrahim

@rays22 This is the suggested change to the name of the pattern, 'proportion_of_attributes', based on the PATO class 'proportionality_to'. I also created a tsv file for the pattern and generated a term as an example. I still think we may need to create an additional pattern where the variables are 'attribute1, attribute2, location'. This is to avoid creating a large number of new terms. For example if we want to create the ratio 'sputum sodium to sputum potassium ratio' we would need to create those two terms first. That would not be necessary if the variables include the location.

ar-ibrahim avatar Sep 18 '23 11:09 ar-ibrahim

I have consulted @rays22 about the recurring QC warnings and as per my understanding this has been an outstanding issue that does not prevent merging the PR should the suggested changes be approved.

ar-ibrahim avatar Oct 03 '23 10:10 ar-ibrahim