Harmonise labels in OBA

[matentzn]

Right now, OBA terms have a wild variety of patterns for representing labels:

• ENTITY trait, e.g. head trait
• ENTITY attribute, e.g. chemical entity attribute
• attribute of X, e.g. attribute of cell
• ENTITY ATTRIBUTE, e.g. cell size
• ENTITY ATTRIBUTE trait, e.g. eye size trait
• trait ATTRIBUTE ENTITY, e.g. trait in response to glucose

I would suggest we try to drop as much of the trait terminology as possible:

• rename head trait to head attribute ? sounds weird. Maybe use attribute of cell pattern here?
• rename eye size trait to eye size (see @megbalk comment below)
• What about trait in response to glucose?

What do you think @rays22 @megbalk

• [ ] Add QC check for all permissible naming patterns

[meghalithic]

I agree. Based on issue #90, I think we wanted to have "attribute" as the parent term, then terms like "size" or "shape" as subclasses.

[matentzn]

Thanks @megbalk I updated my comments above.