Michael Adam

deviating from the approach chosen in the first patches, I am starting to think about adding the reading of the operator setting to https://github.com/rook/rook/blob/master/pkg/operator/ceph/controller/controller_utils.go so that the value can be...

> deviating from the approach chosen in the first patches, I am starting to think about adding the reading of the operator setting to https://github.com/rook/rook/blob/master/pkg/operator/ceph/controller/controller_utils.go so that the value can...

> > deviating from the approach chosen in the first patches, I am starting to think about adding the reading of the operator setting to https://github.com/rook/rook/blob/master/pkg/operator/ceph/controller/controller_utils.go so that the value...

@travisn , @BlaineEXE I have started the re-implementation roughly along the lines you sketched. I guess This still does not cover all necessary places. I will continue.

The newly introduced unit test `TestSetEnforceHostNetwork` is failing and I am not yet certain why.

> The newly introduced unit test `TestSetEnforceHostNetwork` is failing and I am not yet certain why. Problem found and fixed.

@BlaineEXE . @travisn : thanks to your help, this work is progressing. Places covered: * `pkg/operator/ceph/cluster/cleanup.go` * `kg/operator/ceph/object/cosi/spec.go` * `pkg/operator/k8sutil/cmdreporter/cmdreporter.go` Are any missing?

@BlaineEXE wrote: > the OSD provisioner pod, discovery daemon, all 3 CSI provisioners, and COSI driver. Thanks for the list! I think I have covered OSD provisioner, discovery and COSI...

> @BlaineEXE wrote: > > > the OSD provisioner pod, discovery daemon, all 3 CSI provisioners, and COSI driver. > > Thanks for the list! > > I think I...

@BlaineEXE wrote: > Changes look good, but Madhu has noted a golang code convention issue with `if err != nil { val = false }`. Let's remove the `val =...