Michael Adam
Michael Adam
failure in the macos build ci check: ``` vet: pkg/apis/ceph.rook.io/v1/network_test.go:52:21: unknown field provider in struct literal of type NetworkSpec ``` I guess something did not go quite right with my...
> failure in the macos build ci check: > > ``` > vet: pkg/apis/ceph.rook.io/v1/network_test.go:52:21: unknown field provider in struct literal of type NetworkSpec > ``` > > I guess something...
This PR is now based on #13693
> > We should also add logic that seems to be missing where users are currently allowed to set `hostNetwork: true` at the same time as `network.provider: ""` which should...
still trying to fix build/vet errors. This is what I see locally: ``` $ make -j build ... pkg/operator/discover/discover.go:124:25: undefined: c # github.com/rook/rook/pkg/operator/ceph/cluster pkg/operator/ceph/cluster/cleanup.go:164:25: c.spec undefined (type *ClusterController has no...
I discussed this with @BlaineEXE on Friday and we want to change the direction of our approach for this PR, roughly along the lines sketched in this recent comment: https://github.com/rook/rook/pull/13651#pullrequestreview-1883858027...
@subhamkrai , I am not quite convinced that I would consider the need to refactor code as a bug. sounds like technical debt to me. Addressing this would result in...
A quick look through the code (with `git grep -i ishost\(`) seems to tell me that the CephCluster's HostNetwork setting is already correctly propagated to most of the ceph component...