react-native-vector-icons icon indicating copy to clipboard operation
react-native-vector-icons copied to clipboard

Published 20 hours ago • verified publisher icon oblador

Add support for FontAwesome 6

Open basbase opened this issue 2 years ago • 2 comments

#1408

basbase avatar Aug 04 '22 21:08 basbase

:+1: Let's goooooo :D

cdownard avatar Sep 01 '22 16:09 cdownard

I wrote some comments, but they are only recommendations LGTM 👀❤️

In this case, it should also be changed there: https://github.com/oblador/react-native-vector-icons/blob/master/FONTAWESOME5.md#usage

rvasseur31 avatar Sep 05 '22 14:09 rvasseur31

Neat! Thanks for this!

a-tokyo avatar Sep 26 '22 10:09 a-tokyo

Hey guys, any update here? 👀

mgruntowski avatar Dec 07 '22 14:12 mgruntowski

@johnf Can you please review this again so we can merge? ✨

a-tokyo avatar Dec 08 '22 19:12 a-tokyo

@johnf Can you please review this again so we can merge? sparkles

Not sure if my review will matter, I'm not a maintainer? If @basbase isn't around to make more changes, I'm happy to take this on and get it into a mergable state though. I would probably

  • Add support for the other icon types
  • Look at merging the scripts into a single script that asks which fontawesome you want

johnf avatar Dec 08 '22 20:12 johnf

I don't have time to make changes to this any more. It's working for me and the requested changes could be done later.

basbase avatar Dec 19 '22 08:12 basbase

Can we merge this?

a-tokyo avatar Mar 03 '23 12:03 a-tokyo

Alternative: Official FontAwesome library for React Native

a-tokyo avatar Mar 03 '23 12:03 a-tokyo

How did you generate the glyphmaps? I see FA6 now has some new styles and would be happy to contribute to this PR to bring it up to date as its holding back creativity!

TheDistanceHQ avatar Jun 09 '23 09:06 TheDistanceHQ

When this is gonna be merged?

naleon avatar Jun 16 '23 20:06 naleon

Superseded by #1483

oblador avatar Jul 17 '23 12:07 oblador