react-native-vector-icons icon indicating copy to clipboard operation
react-native-vector-icons copied to clipboard

Update to latest Material Icons by Google and add outlined Material Icons

Open jsproede opened this issue 4 years ago • 14 comments
trafficstars

Hi,

it looks like that the referenced Material Icons commit hash was not the latest hash of the v4.0.0 Material Icons. We've updated the commit hash reference to the newest hash.

Additionally we needed the outlined Material Icons and added them to this repository. For the outlined Material Icons we needed to install FontForge (brew install fontforge) which converts the .otf file to a .ttf file, because Google provides the outlined Material Icons only as .otf file. We've added this dependency to the CONTRIBUTING.md file because it is required to update the outlined Material Icons.

In conclusion:

  • We updated the commit hash of the Material Icons to the newest one
  • Added the outlined Material Icons as described above
  • Added FontForge as requirement (CONTRIBUTING.md)
  • Ran the tests: npm test
  • Updated the README.md and added the MaterialIconsOutlined entry
    • We also updated the amount of the available icons

Unfortunately the script npm run build does not work:

Archive:  /var/folders/.../entypo.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.

This is the last step to fulfill all steps of your contribution guidelines.

If there is anything missing, feel free to let us know and we'll update this pull request 🙂

jsproede avatar Aug 24 '21 13:08 jsproede

i hope the outlined version of this icon is going to be part of the udpate. 🤞 🙏 https://fonts.google.com/icons?selected=Material+Icons&icon.query=no+photo

vitogoh avatar Sep 22 '21 21:09 vitogoh

Hi @vitogoh. Yes, the outlined no-photography icon is included in this PR :) As we needed some of the new and outlined icons in one of our projects, we've installed our fork directly in our projects package.json:

"react-native-vector-icons": "nanogiants/react-native-vector-icons#feature/materialicons"

jsproede avatar Sep 23 '21 05:09 jsproede

Hi @vitogoh. Yes, the outlined no-photography icon is included in this PR :) As we needed some of the new and outlined icons in one of our projects, we've installed our fork directly in our projects package.json:

"react-native-vector-icons": "nanogiants/react-native-vector-icons#feature/materialicons"

👍

vitogoh avatar Sep 28 '21 20:09 vitogoh

@oblador sorry for mentioning but is there anyway to merge this PR, since it brings lots of improvements and it has been some time since the author created this PR

svbutko avatar Oct 06 '21 08:10 svbutko

This PR includes the icons which I really need: "password" and "tips and updates"

CyxouD avatar Nov 29 '21 09:11 CyxouD

I got Unrecognized font family 'Material Icons Outlined error on iOS (iPhone 11 simulator, iOS 15.0, react-native 0.63.4). To fix it I also had to add UIAppFonts in Info.plist (as described in manual setup for iOS). In my case it is

	<key>UIAppFonts</key>
	<array>
  	<string>MaterialIconsOutlined.ttf</string>
  	<string>MaterialCommunityIcons.ttf</string>
	</array>

@jsproede could it be the issue with the PR?

image

CyxouD avatar Nov 29 '21 10:11 CyxouD

Hi @CyxouD,

it looks like that the Material Icons Outlined font could not be loaded. Did you add the MaterialIconsOutlined.ttf to your Fonts folder in Xcode as described in the documentation you've linked in your last comment? :)

Fonts

jsproede avatar Nov 30 '21 07:11 jsproede

Hi @jsproede!

Actually, it was enough for me just to change Info.plist without copying Fonts folder. I've added project with Cocoapods option and just found out that it was required to Edit Info.plist as described above.. I don't know how it used to work before (without the change to Info.plist), but now we know that is my mistake to not edit Info.plist. I'm sorry to trouble you!

Thank you for your PR, it really helps!

CyxouD avatar Nov 30 '21 07:11 CyxouD

Any activity on this?

mattahorton avatar Jan 18 '22 22:01 mattahorton

@jsproede @oblador Seems like a busy guy, but he mentioned in his readme to reach out to him over Twitter (https://twitter.com/trastknast). Maybe you could take some maintenance work from him if you got the time.

Even just bumping the icon version on a regular basis would help out a lot for many people.

sutefan1 avatar Jan 24 '22 16:01 sutefan1

Any update on this?

ser-emejia avatar May 03 '22 18:05 ser-emejia

Any news about this merge ?

krambout-seche avatar Jul 13 '22 10:07 krambout-seche

Unfortunately, I never got a response from @oblador. We also tried to reach him via Twitter.

jsproede avatar Jul 14 '22 16:07 jsproede

Bumping this up, I'm also interested in this PR

tux2nicolae avatar Sep 07 '22 08:09 tux2nicolae

Any plans to merge this PR?

yo9e5h avatar Oct 15 '22 17:10 yo9e5h

It would be lovely if this PR is approved :)

Max-DVS avatar Oct 19 '22 18:10 Max-DVS

Bumping this up, would be nice to update the MaterialIcons lib

hyetigran avatar Nov 21 '22 17:11 hyetigran

Bump

wanschi avatar Dec 02 '22 09:12 wanschi

+1 Bump

smisaacs avatar Apr 17 '23 16:04 smisaacs

+1 bump, having to patch this package locally with these changes

alex-lanclos avatar Apr 17 '23 18:04 alex-lanclos

react-native-vector-icons+9.2.0.patch

You can have this running on your projects without having to fork if you use the above patch and use

"copyFiles": [
   {
     "from": "<Point to font>/MaterialIcons.ttf",
     "to": "node_modules/react-native-vector-icons/Fonts/MaterialIcons.ttf"
   },
   {
     "from": "<Point to font>/MaterialIconsOutlined.ttf",
     "to": "node_modules/react-native-vector-icons/Fonts/MaterialIconsOutlined.ttf"
   }
 ]

and have

npx copy-files-from-to --when-file-exists overwrite

run as part of your postinstall

alex-lanclos avatar Apr 18 '23 20:04 alex-lanclos

The material icons of this library are outdated, can the author of this repo merge this commit?

topzdev avatar May 11 '23 13:05 topzdev

Material Icons has been updated since this PR was created. If someone is willing to create a PR for Outline support I'll be happy to review and merge. I suggest doing this in a similar way to FontAwesome where it uses the existing Element but we add a variant/style field to pick outline, sharp etc

johnf avatar Oct 28 '23 22:10 johnf