react-native-shimmer icon indicating copy to clipboard operation
react-native-shimmer copied to clipboard
verified publisher icon oblador

Remove assertion

Open piaskowyk opened this issue 4 years ago • 0 comments

Hello, I am the react-native-reanimated maintainer. We received an issue related to your library - https://github.com/software-mansion/react-native-reanimated/issues/2554 This issue has two potential solutions:

  • Add try {} catch by Reanimated side - https://github.com/software-mansion/react-native-reanimated/pull/2624
  • Remove assertion from Shimmer side - like in this PR

An IMO better way is removing an assertion because I don't see clearly the case to use it here. Is this assertion really needed? It is possible to remove this assertion?

piaskowyk avatar Nov 12 '21 10:11 piaskowyk