react-native-lightbox icon indicating copy to clipboard operation
react-native-lightbox copied to clipboard

let overlay can be zoomed && add renderMask func && add gallery mode.

Open ZackLeonardo opened this issue 7 years ago • 11 comments

The overlay can be zoomed and drag. Add doubleTap feature to zoom in/out.

ZackLeonardo avatar Sep 27 '17 03:09 ZackLeonardo

Good PR! Thanks! @oblador Is it possible to merge this?

hoscarcito avatar Jan 02 '18 12:01 hoscarcito

should be merged +1

sadi304 avatar Feb 23 '18 10:02 sadi304

should be merged +1

mengpeilee avatar Apr 05 '18 19:04 mengpeilee

add renderMask func which can be used with renderContent together to make image->video easier. for example: renderMask simulator screen shot - iphone 6s - 2018-04-11 at 13 35 52 and renderContent simulator screen shot - iphone 6s - 2018-04-11 at 13 40 34

ZackLeonardo avatar Apr 11 '18 05:04 ZackLeonardo

add gallery mode. <Lightbox ... galleryMode={true} GKey={'xxx'}>

lightbox gal

lightbox

ZackLeonardo avatar Apr 15 '18 10:04 ZackLeonardo

Hi @ZackLeonardo Could you explain how the gallery works? At the moment I'm using the Carousel component inside the lightbox and it offers a nice transition between images. Is yours offering a transition? Also, if I have a flatlist with elements, How I can pick one element and show it in the layout and start the gallery from that index? Thanks!

hoscarcito avatar Apr 22 '18 05:04 hoscarcito

@hoscarcito This PR offers a transition. I have store the indexes of all children props of lightbox in global map, which the key is GKey props and the value is array of indexes. When one children component is selected, it will show in lightboxOverlay. When swiped change the children component to make it a transition. This gallery mode PR is offering a simple transition now, it will be better performed such as the other carousel components.

ZackLeonardo avatar Apr 23 '18 02:04 ZackLeonardo

I will give it a try! I'm using the gallery solution provided in the docs (nice transition) but to make it work I need to disable the swipeToDismiss as It's messing it with the nested panResponders. Also, I'm showing a specific footer for each image so I will need to modify your code to check which item it's showing. Thank you!!!

hoscarcito avatar Apr 23 '18 02:04 hoscarcito

should be merged +1

clementinoux avatar Apr 30 '18 09:04 clementinoux

Just be curious if the useNativeDriver prop could be supported

peteroid avatar May 09 '18 10:05 peteroid

should be merged +1

BaderSerhan avatar May 30 '18 12:05 BaderSerhan