oblador
Android AES GCM support via preferedCipher option
@pcoltau Unfortunately, this was @Skvuddudutt's last assignment before his contract ended, so wouldn't assume it will be done. Can maybe help with cleaning up some of it later, but would be good if you could glance at the general approach first and see if you think it's worth continuing working on.
Yeah sorry I was unclear. I did the PR to "save" the partial work I was doing but didnt have time to finish. It hasnt been really tested and still contains a bunch of logging. Also I think there is an issue with read behaviour and auto migrating IIRC. I wont be doing any more work on it.
As Joel said, you might want to just look at it and see if it is something you want to finish or just throw it away.
On 5 April 2018 at 07:46, Pelle Stenild Coltau [email protected] wrote:
@oblador https://github.com/oblador
Fair enough - I'll give it a look as soon as time permits..
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oblador/react-native-keychain/pull/123#issuecomment-378826702, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwN77f1RQnz8RnOEm0VXNdU1tftNrCaks5tla-pgaJpZM4TAKe5 .
My review of this is done.
As @Skvuddudutt says, we need to address some issue before we can merge this. We just need to figure out who should do that. I can't promise that I'll have the time in the near future..
@pcoltau can you clarify what issue needs to be addressed? If it's "read behaviour and auto migrating IIRC," could you expand that?
@pcoltau can you clarify what issue needs to be addressed? If it's "read behaviour and auto migrating IIRC," could you expand that?
I forgot to "commit" my review comments 🙄- that is done now. Let me know if you have any questions.
I see this PR #513 is doing the same think. Maybe it's more up to date with the master?
