react-native-collapsible icon indicating copy to clipboard operation
react-native-collapsible copied to clipboard

Calling `getNode()` on the ref of an Animated component is no longer necessary

Open Ho3ein-Boka opened this issue 4 years ago • 11 comments

Calling getNode() on the ref of an Animated component is no longer necessary. You can now directly use the ref instead. This method will be removed in a future release.

Ho3ein-Boka avatar Apr 06 '20 03:04 Ho3ein-Boka

This should be corrected by #346 .. Any ETA?

pistou avatar Apr 08 '20 12:04 pistou

ReactNativeFiberHostComponent: Calling getNode() on the ref of an Animated component is no longer necessary. You can now directly use the ref instead. This method will be removed in a future release.

Still continue in last version.

marcoaras avatar Apr 18 '20 16:04 marcoaras

Solucion 25a7ad2

image

JeanRoldanDev avatar Apr 25 '20 04:04 JeanRoldanDev

Solucion 25a7ad2

image

When will this merged please.

OsamaMukhtar avatar May 08 '20 08:05 OsamaMukhtar

+1 this really needs to be merged and corrected.

nashford77 avatar May 11 '20 01:05 nashford77

+1 Waiting for PR to be merged

renishg avatar May 12 '20 14:05 renishg

+1 did the maintainer die of corona virus or something?

awkpagong avatar May 21 '20 18:05 awkpagong

Did someone find a solution for this?

Edit:

In file https://github.com/oblador/react-native-collapsible/blob/master/Collapsible.js on line 88: removing the getNode() function from the chain fixes the issue.

leurs247 avatar Jun 12 '20 12:06 leurs247

@yesterday24 I used patch-package to apply @marcorm's fix #346 to my project while we wait for the fix to be merged into the react-native-collapsible repo

Edit:

@yesterday24 for your use case, if you are locked into RN 0.62 or higher, you could create a patch that does what you mentioned in your comment and ignore the backwards compatibility part of marcorm's fix if you don't need backwards compatibility

Edit 2:

This issue is fixed now in version 1.5.3, so the patch workaround is no longer necessary once you upgrade: https://github.com/oblador/react-native-collapsible/pull/349

willcaul avatar Jun 16 '20 10:06 willcaul

same problem here

elpolyglotino avatar Jun 16 '20 19:06 elpolyglotino

Why can't I install version 1.5.3? image image

liran avatar Aug 18 '20 10:08 liran