loki icon indicating copy to clipboard operation
loki copied to clipboard

Not working with React Native Storybook 6.5

Open tamlyn opened this issue 1 year ago • 6 comments

First of all Loki looks 😍 !

But it doesn't seem to support React Native Storybook 6.5 (which was finally released a few weeks ago after years of development).

$ yarn loki init
loki init v0.31.1
Storybook config path not found at "storybook", try passing a --config argument

The new version uses the same .storybook/main.js config file as web storybook, so it may be possible to remove some RN special cases like this:

https://github.com/oblador/loki/blob/8beda16fcda4841c4e23c7353880e94498cbadcc/packages/runner/src/commands/init/index.js#L70-L71

Aside from superficial changes like this, does anyone have an idea of what will be required to make it work?

tamlyn avatar Apr 17 '23 16:04 tamlyn

Hey! I started to looking at it and there were some large internal changes to storybook that broke Loki. I feedback that to the RN SB maintainer who made some changes, I just need to restart this process again and I've been short on time lately. It's a goal to support it 👍 If you're up for it I'd be happy if you took a stab, but I'm not sure if it's trivial as a first contribution,

oblador avatar Apr 17 '23 17:04 oblador

@oblador I could try to help you out. Do you have some changelog that I could look at and try to support the new changes on RN SB?

slavikdenis avatar Oct 17 '23 08:10 slavikdenis

Hi, I am also having compatibility issues with React NativeStorybook v6.5. Is there a timeline on when it will be supported? Thanks!

danchen86 avatar Oct 24 '23 21:10 danchen86

Any workarounds or issues to solve?

januswel avatar Dec 08 '23 01:12 januswel

@slavikdenis any updates? I'm happy to help but need some guidance

nehahirve92 avatar Mar 27 '24 14:03 nehahirve92

or maybe @techeverri can point me where to start?

nehahirve92 avatar Mar 27 '24 15:03 nehahirve92