objectiv-analytics icon indicating copy to clipboard operation
objectiv-analytics copied to clipboard

Published 20 hours ago • verified publisher icon objectiv

Bach BQ: migrate tests that use get_bt_with_test_data()

Open thijs-obj opened this issue 3 years ago • 1 comments

  • Migrate tests that use get_bt_with_test_data() to use get_df_with_test_data() instead
  • When migration of a test is non-trivial create separate issues for those tests

List of sub-issues and related issues:

  • https://github.com/objectiv/objectiv-analytics/issues/1024
  • https://github.com/objectiv/objectiv-analytics/issues/1025
  • https://github.com/objectiv/objectiv-analytics/issues/1026
  • https://github.com/objectiv/objectiv-analytics/issues/1027
  • https://github.com/objectiv/objectiv-analytics/issues/833
  • https://github.com/objectiv/objectiv-analytics/issues/973

thijs-obj avatar Jun 01 '22 09:06 thijs-obj

PR https://github.com/objectiv/objectiv-analytics/pull/1105 replaces usage of get_bt_with_test_data() with get_df_with_test_data() in conjunction with pg_engine. The tests still need to be migrated to actually work with BigQuery tho

thijs-obj avatar Aug 03 '22 14:08 thijs-obj

Going to close this issue: The main effort here has been done. All test tests use get_df_with_test_data().

Converted tests that are not yet working on all platforms are annotated with a skip_<db name>_todo marker. So we have visibility on what still needs to be done.

thijs-obj avatar Oct 17 '22 15:10 thijs-obj