objectiv-analytics icon indicating copy to clipboard operation
objectiv-analytics copied to clipboard

Published 20 hours ago • verified publisher icon objectiv

Fix BQ tests.functional.bach.test_df_scale.test_min_max_scale

Open thijs-obj opened this issue 3 years ago • 1 comments

MinMaxScaler doesn't seem to respect sorting well.

Items:

  • Make sure MinMaxScalar works well if the DataFrame has sorting set. This seems to be an issue
  • Make tests.functional.bach.test_df_scale.test_min_max_scale pass. Probably sorting the data beforehand will fix this
  • Make sure test doesn't do too many queries. If needed split up so queries will be better distributed over tests.

thijs-obj avatar Jul 14 '22 13:07 thijs-obj

The test seems to pass now. But the other points still stand: there is something with the sorting, see the TODO in the code, and the test is slow.. This issue is NOT solved.

thijs-obj avatar Sep 06 '22 18:09 thijs-obj