eoc icon indicating copy to clipboard operation
eoc copied to clipboard

feat(): add preflight before main commands run

Open antonbashmakov opened this issue 10 months ago • 10 comments

PR-Codex overview

This PR updates preflight checks and licensing information.

Detailed summary

  • Added licensing information to preflight files
  • Implemented preflight checks in multiple commands
  • Added shell export in mvnw.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

antonbashmakov avatar Apr 05 '24 08:04 antonbashmakov

@yegor256 tests failing on different platforms, does not seem to be problem in my code, is it an known issue?

antonbashmakov avatar Apr 08 '24 17:04 antonbashmakov

@antonbashmakov this is weird, but the build seems to be stable in the master branch.

yegor256 avatar Apr 09 '24 06:04 yegor256

@yegor256 seems like inspects foreign objects and prints a report is failing for windows the very same test is ok on Ubuntu. This code does not trigger function I wrote, so it should not be a problem. Can any one check tests on a windows machine?

antonbashmakov avatar Apr 09 '24 07:04 antonbashmakov

@antonbashmakov let's make a separate ticket about this, we will try to fix

yegor256 avatar Apr 09 '24 09:04 yegor256

@yegor256 the error seems to be inconsistent, I pushed a trigger commit and now it is different result. Will any one take a look at the MR?

antonbashmakov avatar Apr 09 '24 11:04 antonbashmakov

@yegor256 interesting enough, the JSON generated by failing test is indeed broken :

{ "id": "org.eolang.ram", "discovered": "13", "xmir": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/1-parse/org/eolang/ram.xmir", "optimized": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/2-optimize/org/eolang/ram.xmir", "scope": "compile", "eo": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/4-pull/org/eolang/ram.eo", "jar": "org.eolang:eo-runtime:0.35.8", "shaken": "/home/runner/work/eoc/eoc/temp/test-foreign/simple/target/3-shake/org/eolang/ram.xmir", "version": "0.35.8", "probed": "0", "hash": "d9c8741" } ]hash": "d9c8741" } ] Unexpected token h in JSON at position 18065

I tried to disable my changes but the error remains

antonbashmakov avatar Apr 09 '24 12:04 antonbashmakov

@yegor256 seems like all MR lately has the same problem. Like this one for instance

antonbashmakov avatar Apr 09 '24 13:04 antonbashmakov

@yegor256 ok, seems like version 0.35.8 of the plugin is behaving. It is some thing with 0.35.11 which makes it sad.

antonbashmakov avatar Apr 09 '24 13:04 antonbashmakov

@antonbashmakov let's make a separate issue and fix this problem over there

yegor256 avatar Apr 09 '24 15:04 yegor256

@yegor256 I think we should attack this problem in order to fix the pipelines. have you created a ticket for it?

UPD: I created it here

antonbashmakov avatar Apr 11 '24 07:04 antonbashmakov