eo icon indicating copy to clipboard operation
eo copied to clipboard

Duplication between Param & Dataized

Open andreoss opened this issue 2 years ago • 1 comments

Param & Dataized & Data.ToPhi do similar operations Dataized almost not used directly. ToPhi always consumes results of Param Proposal:

  1. Join Param and Dataized
  2. Make Dataized implement Phi as a smart-class with extra methods So instead of
new Data.ToPhi(new Dataized(...).take(Long.class) + 1)

we could write

new DataizedPhi(phi).as(Long.class).apply(x -> x + 1)

andreoss avatar Dec 26 '21 23:12 andreoss

@andreoss I added some explanation at bff11216 As for the other idea about DataizedPhi, I suggest we put it on hold for a while. I will think more about it.

yegor256 avatar Dec 28 '21 16:12 yegor256

@yegor256 Are we going to continue here?

volodya-lombrozo avatar Mar 31 '23 11:03 volodya-lombrozo

@andreoss I'm closing this, since it's pretty debatable and we are pretty stable in this part of the code

yegor256 avatar Mar 31 '23 15:03 yegor256