eo icon indicating copy to clipboard operation
eo copied to clipboard

fix: rename VTX -> VERTEX

Open deemp opened this issue 2 years ago • 12 comments

Make the name more understandable


PR-Codex overview

This PR renames VTX to VERTEX in the Phi grammar and Java code for consistency and clarity.

Detailed summary

  • Renamed VTX to VERTEX in the Phi grammar file.
  • Updated references of VTX to VERTEX in Java code for attribute binding.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

deemp avatar Jan 11 '24 12:01 deemp

@maxonfjvipon take a look

yegor256 avatar Jan 11 '24 16:01 yegor256

@deemp to get the build successful you need to fix the usages of VTX in XeEoListener.java file

maxonfjvipon avatar Jan 11 '24 17:01 maxonfjvipon

@maxonfjvipon, XeEoListener.java doesn't have occurences of VTX.

deemp avatar Jan 11 '24 20:01 deemp

@deemp sorry, my bad, you need XePhiListener

maxonfjvipon avatar Jan 11 '24 20:01 maxonfjvipon

There are some other occurences. Should I fix them too?

image

deemp avatar Jan 11 '24 20:01 deemp

@deemp I believe XePhiListener should be enough

maxonfjvipon avatar Jan 11 '24 21:01 maxonfjvipon

@maxonfjvipon, any other changes are necessary?

deemp avatar Feb 01 '24 17:02 deemp

@deemp please update master branch in your fork, merge it to your rename-vtx branch, replace all VTX to VERTEX in Phi.g4 and XePhiListener.java and try to push one more time

maxonfjvipon avatar Feb 02 '24 15:02 maxonfjvipon

@maxonfjvipon, done

deemp avatar Feb 22 '24 11:02 deemp

@deemp everything seems right, please try to restart pipeline one more time

maxonfjvipon avatar Feb 28 '24 09:02 maxonfjvipon

@maxonfjvipon, I can't restart the pipeline.

deemp avatar Feb 28 '24 10:02 deemp

@deemp just make a commit and push

maxonfjvipon avatar Feb 28 '24 10:02 maxonfjvipon

@maxonfjvipon CI passed

deemp avatar Feb 28 '24 21:02 deemp

@yegor256 please check

maxonfjvipon avatar Mar 02 '24 16:03 maxonfjvipon

@rultor merge

yegor256 avatar Mar 03 '24 06:03 yegor256

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor avatar Mar 03 '24 06:03 rultor

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 23min)

rultor avatar Mar 03 '24 06:03 rultor