app-architecture icon indicating copy to clipboard operation
app-architecture copied to clipboard

Incorrect Keys in FolderViewController Causing Wrong Animations

Open brynbodayle opened this issue 6 years ago • 1 comments

These keys in FolderViewController are reversed and cause some changes to call reloadData instead of the correct insert animation. This incorrect code is in the book as well.

let oldValue = userInfo[Item.newValueKey]
let newValue = userInfo[Item.oldValueKey]

https://github.com/objcio/app-architecture/blob/master/Recordings-MVC/Recordings/FolderViewController.swift#L42-L43

brynbodayle avatar Jul 26 '18 19:07 brynbodayle

Confirmed, switch the values to make animation work correctly.

OmranK avatar Jan 13 '20 01:01 OmranK