trustfall

trustfall copied to clipboard

Unclear error message when parsing a schema containing a field with undeclared type

1

``` thread 'main' panicked at 'internal error: entered unreachable code: field value_as_url (type Url) appears to represent neither an edge nor a property', C:\Users\_\.cargo\registry\src\index.crates.io-6f17d22bba15001f\trustfall_core-0.5.0\src\schema\mod.rs:399:17 ```

u9g

Implementing __typename for types that share a vertex variant is fiddly

1

Any way we can improve the experience on that with the trustfall derive macro?

u9g

Consider this schema: ```graphql type Post { content: String! author: User # or optionally `User!` -- same in both cases } type User { name: String! } ``` and this...

obi1kenobi

Based on this pr: https://github.com/obi1kenobi/trustfall/pull/339 it's super easy to implement one case of CandidateValue and forget about the rest, so a helper for implementing the Single/Multiple cases might be helpful....

u9g

For example, on the "numbers" schema: ```graphql query { Four { predecessor @fold @recurse(depth: 5) { value @output } } } ``` This should return: ```json { "value": [4, 3,...

obi1kenobi

>> I have noticed in main.rs and at other points is the handling of paths as strings. I'm not sure, but could this be a problem for Windows users? `std::path::Path`...

obi1kenobi

Error handling from Adapters?

3

I'm currently trying to understand how to write an adapter via examples _(not the easiest, but it's something)_, and interestingly it appears there's no meaningful error handling. In many cases...

leeola

Suggestion: Add demo on how to combine adapters

1

I'm not sure what the aim is right now, but a desirable ecosystem would be that it is possible to combine different adapters (like a general `trustfall_github_adapter`) with some custom...

ginger51011

Make it possible for query result iterators to be `Send`

1

Right now, none of our code or tests check whether the result iterator will be `Send`, and I believe it is currently not `Send`. Making it `Send` would make it...

obi1kenobi

Consider making `schema::Schema` fields public for testing

2

I have been experimenting a bit with constructing a single source of truth when developing an adapter. Here is the general idea I'm using right now - Use a `src/schema.trustfall.graphql`...

ginger51011