trustfall icon indicating copy to clipboard operation
trustfall copied to clipboard

Tracking issue: Clearer, more effective error messages

Open obi1kenobi opened this issue 2 years ago • 0 comments

We should aim to always be improving the quality of our error messages.

Here are outstanding issues with them:

  • [ ] Errors don't currently include span information. This is a big lift and will require plumbing that information throughout the frontend.
  • [ ] When a query fails to validate against the schema, .unwrap() on the Result produces a Debug-style printout like CompilationError(ValidationError(NonExistentPath(["CrateDiff", "baseline", "item", "Enum", "variant", "StructVariant", "field"]))). This is not ideal:
    • [ ] it should clearly mention the problem is that the query didn't match the schema
    • [ ] it should ideally include Display output rather than Debug output
    • [ ] perhaps the naming can be better as well?

obi1kenobi avatar Oct 19 '22 20:10 obi1kenobi