trustfall icon indicating copy to clipboard operation
trustfall copied to clipboard

feat: Refactor test suite for trustfall_wasm [WIP]

Open devanbenz opened this issue 1 year ago • 7 comments

  • Currently a WIP
  • Moving inline javascript out in to its own separate modules
  • Attempting to fix node tests --stupid ESM/CommonJS >:(--
  • Adding more test coverage
  • Migrating JS --> TS

devanbenz avatar Feb 14 '24 14:02 devanbenz

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

devanbenz avatar Feb 14 '24 14:02 devanbenz

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

Yeah, it's been really frustrating to be honest. Real Python 2 vs Python 3 vibes.

obi1kenobi avatar Feb 14 '24 14:02 obi1kenobi

Will be coming back to this PR over the weekend! I was out of town last week/over the weekend :D

devanbenz avatar Feb 28 '24 00:02 devanbenz

Hey! Just checking in to see if you're still thinking about working on this, or if you got blocked on something I could help with.

No worries if you had other stuff come up, or if for whatever reason you can't work on it anymore. Stuff happens, and I appreciate your help here!

obi1kenobi avatar Mar 11 '24 01:03 obi1kenobi

Hey! Yeah I've been really busy with work lately 🙃 If someone else is interested in taking this on feel free to reassign. I'm hoping to have some more free time after I finish up a project that's "crunch time" at work.

devanbenz avatar Mar 13 '24 11:03 devanbenz

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

obi1kenobi avatar Mar 14 '24 15:03 obi1kenobi

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

Definitely still interested - would love to contribute more as I start to have more free time in the next coming weeks :D

devanbenz avatar Mar 16 '24 17:03 devanbenz