cargo-semver-checks icon indicating copy to clipboard operation
cargo-semver-checks copied to clipboard

cargo semver-checks might exit 0 if it finds only `publish = false` crates in a workspace

Open rcoh opened this issue 1 year ago • 1 comments

  1. Create a cargo workspace where all crates are set to publish = false
  2. cargo semver-checks check-release -v Without -v it seems to imply that all is well—it will silently skip all crates. Checking 0 crates is unlikely to be what the user expected, perhaps it should exist non-zero?

rcoh avatar Mar 30 '23 18:03 rcoh

I didn't add a test case specifically for workspaces full of publish = false crates, so I'm not going to close this right now, but #477 does add an explicit error if the selections contain no crates with library targets, so it's possible this case would be handled too.

obi1kenobi avatar Jun 29 '23 04:06 obi1kenobi