cargo-semver-checks icon indicating copy to clipboard operation
cargo-semver-checks copied to clipboard

Strenghten back the derive_trait_impl_removed lint

Open tonowak opened this issue 2 years ago • 0 comments

Describe your use case

Due to changes in the rustdoc, the trait items defined in external crates are no longer present in the generated rustdoc.

A temporary solution was made in the adapter https://github.com/obi1kenobi/trustfall-rustdoc-adapter/pull/24 which adds some hand-written items for the most common Rust built-in traits. This change fixes the tests, but now an user can use a trait that is not in the hand-written list of items and the derive_trait_impl_removed will not find the trait.

Example baseline: an object that implements a trait that is defined in another crate and not from the hand-written list. Example current: the object without this trait. Expected behavior: the derive_trait_impl_removed lint finds this scenario. Current behavior: the derive_trait_impl_removed doesn't find this scenario.

Describe the solution you'd like

A long-term solution would be to implement in the adapter the support for rustdocs of foreign crates.

Alternatives, if applicable

No response

Additional Context

No response

tonowak avatar Jan 03 '23 22:01 tonowak