obi icon indicating copy to clipboard operation
obi copied to clipboard

Annotation: hasDbXref option?

Open cmrn-rhi opened this issue 2 years ago • 1 comments

Noticed that OBI does not to use the hasDBXref annotation [http://www.geneontology.org/formats/oboInOwl#hasDbXref] - what annotation should be used for database cross-references?

cmrn-rhi avatar Aug 09 '22 03:08 cmrn-rhi

OBI used IAO_0000119:definition source to reference the terms in other resources.

Generally OBI does not provide the mapped terms in other resources in the ontology. When OBI wants to use a term in an existing ontology, OBI will import the term if it is in the active OBO Foundry ontology. Otherwise, OBI will create a new term in the OBI and use IAO_0000119:definition source to indicate the source of definition of the term.

The annotation of hasDBXref is not used consistently in the OBO Foundry ontologies that why it is not used in the OBI.

Here are some discussions related to your question: https://github.com/dcppc/metadata-matrix/issues/2 https://github.com/information-artifact-ontology/ontology-metadata/issues/31

zhengj2007 avatar Oct 03 '22 21:10 zhengj2007

The GenEpiO group circled back to this today in discussion. We have a plan to mint lots of GenEpiO terms, then gradually have them migrate to other ontologies like OBI. For our end-users we'd like to enable an OLS search on a deprecated GenEpiO id to directly yield its updated OBI term after the deprecation occurs. We assume we can't have OBI add hasDbXref pointing to the deprecated GenEpiO term ...

A solution:? Is it ok instead to have GenEpiO annotate an imported OBI term with hasDbXref pointing to deprecated GenEpiO term? That way the GenEpiO term could be found in OLS or OntoBee without users having to have the "search obsolete terms" option turned on (and getting the obsolete term result and its "term replaced by" link leading to new term.)

ddooley avatar Jan 18 '23 22:01 ddooley

@ddooley So you plan to use IAO 'term replaced by' to link from your deprecated GenEpiO term to the replacement OBI term, but you think that will not be enough for OLS search?

jamesaoverton avatar Jan 23 '23 17:01 jamesaoverton

Yes, we'll use IAO term replaced by in the GenEpiO term. But say GenEpiO deprecates a term with label X in favour of OBI term label Y. Now when we search for X in OLS, we find nothing unless we turn on "search deprecated terms". Rather than having to do that, what would be neat is if we actually got a hit on GenEpiO's use of Y, because Y had a hasDBXref annotation in GenEpiO that specifies X.

ddooley avatar Jan 23 '23 20:01 ddooley

This is a user experience thing, as for many users who are not ontologists/curators - if they don't find a term they are looking for, the generally do not know or recall to turn on the deprecated/obsolete term search option.

cmrn-rhi avatar Jan 23 '23 20:01 cmrn-rhi

You have things you need to accomplish, and I see how this would help you get closer. I won't stand in your way. Since you seem to be asking for opinions, my opinions are:

  1. it would be better to just create the terms in OBI in the first place
  2. it just seems wrong to me to change ontology content because of the behaviour of one ontology browser
  3. I don't see why the inverse of 'term replaced by' is 'hasDBXref'
  4. there's a push in OBO not to mess with imported terms, even by adding harmless annotations

jamesaoverton avatar Jan 23 '23 21:01 jamesaoverton

  1. That is what we have tried, but due to long processing time we end up in situations where the controlled vocabulary is needed before they can be processed in the target domain. We're trying to figure out a workflow to deal with terms that take years to process (or get rejected and try again elsewhere).
  2. That's fair, we can try to get more users onto ontobee as at least when there are no results the "show deprecated terms" option is more obvious. We can try to direct users to it more, and get them to follow the "term replaced by" annotation. We have been and still are working on educating people on this process, but it can be overwhelming at times and be seen as a rationale against going the ontology route.
  3. It's not logically the inverse, more it just seemed like an accessible annotation for associating a term with a previously assigned ontology identifier that exists in resources outside of the ontology it has been deprecated in.
  4. I don't think I'm experienced enough in the OBO community to respond to this discussion ~~, but I do think there are reasons to do so within an application ontology on the user-experience side of things - whether that is justified I'm sure is already under debate.~~

cmrn-rhi avatar Jan 23 '23 21:01 cmrn-rhi

~~4. Follow-up: and just to clarify, I mean only within the application ontology with that comment.~~ Just ignore my comments on this. I have a too bad of a headache to convey myself clearly.

cmrn-rhi avatar Jan 23 '23 21:01 cmrn-rhi

So considering OBI uses "definition source" and avoids the ambiguous "hasDBXref", perhaps a better question would be: when requesting to "rehome" a term - would it be feasible to have a "definition source" annotation that references the previous ID or PURL that has been deprecated as a consequence of the "rehoming"?

cmrn-rhi avatar Jan 23 '23 21:01 cmrn-rhi

'definition source' does seem better to me than 'hasDBXref'.

jamesaoverton avatar Jan 24 '23 14:01 jamesaoverton

OMO issue - take it up there. @zhengj2007 will look into it.

ddooley avatar Mar 27 '23 16:03 ddooley