obliteration icon indicating copy to clipboard operation
obliteration copied to clipboard

Use an enum for errors instead of an NonZeroI32

Open ultimaweapon opened this issue 1 year ago • 4 comments

Discussed in https://github.com/obhq/obliteration/discussions/769

Originally posted by SuchAFuriousDeath March 27, 2024 I think this could make some functions better optimized.

ultimaweapon avatar Mar 31 '24 09:03 ultimaweapon

How should the enum be named? PS4Error? PS4Errno?

SuchAFuriousDeath avatar Mar 31 '24 12:03 SuchAFuriousDeath

I totally forget we already used Errno name. No idea about the name yet but we should find a better name than PS4Error and PS4Errno.

ultimaweapon avatar Mar 31 '24 12:03 ultimaweapon

We should use Errno and rename the current Errno trait to something else.

ultimaweapon avatar Mar 31 '24 12:03 ultimaweapon

My idea is AsErrno so it is matched with std.

ultimaweapon avatar Mar 31 '24 12:03 ultimaweapon