obliteration icon indicating copy to clipboard operation
obliteration copied to clipboard

Implement sys_thr_get_name

Open mikusp opened this issue 1 year ago • 3 comments

mikusp avatar Feb 19 '24 18:02 mikusp

I'll check this when I have time.

@ultimaweapon This is unrelated to the PR, but what would you think about doing Vthread::current().unwrap() before a syscall is called and passing it as another argument to all the syscall handlers? I feel like it's kind of redundant to do Vthread::current().unwrap() everywhere when we could do it once and then pass it to the function. Maybe there is an issue with it that I don't see. By pure coincidence, this is actually kind of similar to the actual FreeBSD syscall handlers.

SuchAFuriousDeath avatar Feb 19 '24 18:02 SuchAFuriousDeath

I'll check this when I have time.

@ultimaweapon This is unrelated to the PR, but what would you think about doing Vthread::current().unwrap() before a syscall is called and passing it another argument to all the syscall handlers? I feel like it's kind of redundant to do Vthread::current().unwrap() everywhere when we could do it once and then pass it to the function. Maybe there is an issue with it that I don't see. By pure coincidence, this is actually kind of similar to the actual FreeBSD syscall handlers.

Good idea.

ultimaweapon avatar Feb 20 '24 01:02 ultimaweapon

We are closing this PR due to no any activities in the last 30 days. Feel free to re-open it if you would like to continue working on this.

github-actions[bot] avatar Mar 28 '24 01:03 github-actions[bot]

We are closing this PR due to no any activities in the last 30 days. Feel free to re-open it if you would like to continue working on this.

github-actions[bot] avatar May 20 '24 01:05 github-actions[bot]