added a max parameter to control the graph y axis per graph

[Mmmkayness]

Presently the y axis maximum on graphs will be dependent on the sample of data in the time period visible to the graph. This optional parameter will allow you to fix the max height per graph.

{ "alias": "pulse-events-per-second", "target": "pulse.pulse-events-per-second", "warning": 100, "critical": 500, "max": 600 }

While you could set the max to be the critical value, that won't satisfy cases where Tasseo knows that you have a reverse threshold critical (warning higher than critical).

[obfuscurity]

I'm :+1: on the concept, but the implementation looks flawed to me.

Shouldn't this default to something like this.max = this.max || null and only set max on the Rickshaw object if max != null?

[Mmmkayness]

Please forgive the implementation, it was in haste, and not my forte. I believe the Rickshaw default is 0 if max is not set, a null check may well be more transparent in code though.

I was digging through my old hacks and thought I'd submit this one.

On Friday, January 24, 2014, Jason Dixon [email protected] wrote:

I'm [image: :+1:] on the concept, but the implementation looks flawed to me.

Shouldn't this default to something like this.max = this.max || null and only set max on the Rickshaw object if max != null?

— Reply to this email directly or view it on GitHubhttps://github.com/obfuscurity/tasseo/pull/79#issuecomment-33243754 .