oberblastmeister

Results 71 comments of oberblastmeister

@nmattia My review. I'm nitpicking but at least it removes an `unwrap`

@nmattia It's my fault. The review was pending and I forgot to submit it. You should see it now.

> Re. the details, which `unwrap` do you want me to remove? Do you mean something like this? ```rust if s.starts_with("#") { s.strip_prefix("#").unwrap() } else { ... } ``` can...

I think I like `tm` the best.

I was testing out `swhkd` and found that it cannot find `XDG_CONFIG_HOME`, possibly because of `pkexec`? Is this supposed to be an issue?

@Bodigrim ```haskell -- | O(1) returns the char given the index for the first code unit. -- Panics if the indices are on invalid char boundaries index :: HasCallStack =>...

Well, we already have a lot of partial functions. Libraries like `bytestring` and `vector` have similar functions. Functions that return `Maybe` can be used too. Also, I think, O(1) indexing...

> it still breaks the level of abstraction of "text as a sequence of Char". How does this break the level of abstraction and why does that matter? We are...

I think those functions would be good. I understand now that `Text` should be representation agnostic. Thank you for explaining to me.

I thought about this for a while and I am reopening because I think this is useful and also I thought of a good compromise. First, this function is useful,...