Osakpolor Obaseki

Results 15 comments of Osakpolor Obaseki

Keeping FastBlocks in config while not using it in code might be confusing for cases (however unlikely) where both are set to different values. Also, maybe adding a warning message...

So ignore fast block in the config, and always set it to true if fast sync is true? (the case of fastsync being false is irrelevant) Meaning **keep the interfaces**...

@MarekM25 @marcindsobczak @LukaszRozmej I was able make the changes but i noticed one particular test that had fastbocks set to false even when fastsync was set to true. Since we...

ignore this, I wanted to see all tests that would fail in the case if fastsync was forced. Can't do that locally due to system dependent flaky tests.

I see - so the test needed to change

> @obasekiosa Have you synced one node with one-click to confirm that code works correctly? If you don't know how - let me know! :) I don't know how could...

> Don't know if it is connected, but with 1.26 on MainNet I'm getting > > > Incorrect config settings found: > > ConfigType:JsonConfigFile|Category:SyncConfig|Name:FastBlocks > > And if I check...

Work breakdown structure added in issue description.

> @obasekiosa this link ("More details on [notion](https://www.notion.so/nethermind/Tendermint-consensus-02802797c6ea4cd3be3db3a57ef81819)") is broken - what's the latest version of this article? Ahhh yes thanks!! fixed

> Hi @mr-c , can you talk about this task a bit more, I'm not certain I fully understand it so I haven't been able to work on it. >...