Martyn Janes

If you are using the pure C implementation pearl_diver.c the signature for is_found_fast() causes loss of precision on it's return value. https://github.com/iotaledger/ccurl/blob/94d74a492a7ff9494c73b7be2dcf80f3ce4d453f/src/lib/pearl_diver.c#L154 I have a case where the final lastMeasurement...

Remove method uses wrong JS method

1

The library remove method uses unshift, which is for adding to a list. https://github.com/iotaledger/curl.lib.js/blob/2da1de36123d89b0c7dcababe24f72828bc5f794/src/curl.lib.js#L168 This should be either be shift() if you are trying to remove the current job, or...

If you interrupt a PearlDiver search the code attempts to call the _save method, but is accesses it as an instance methods instead of passing the instance. https://github.com/iotaledger/curl.lib.js/blob/2da1de36123d89b0c7dcababe24f72828bc5f794/src/pearldiver.js#L100 Should be...