notion-rtl icon indicating copy to clipboard operation
notion-rtl copied to clipboard

Database Pages Direction Only Changes After Opening a Nested Page

Open obahareth opened this issue 4 years ago • 5 comments

Database pages are not turned to RTL by default, you have to open a subpage first for it to work.

See the example here: 2021-09-26 15 53 46

obahareth avatar Sep 26 '21 12:09 obahareth

@Fahme Could you check this out? It might be related to the mutation observer.

obahareth avatar Sep 26 '21 12:09 obahareth

p.s. this is fixed in https://github.com/notion-enhancer/repo/blob/dev/right-to-left/client.mjs

dragonwocky avatar Oct 21 '21 03:10 dragonwocky

p.s. this is fixed in https://github.com/notion-enhancer/repo/blob/dev/right-to-left/client.mjs

Thanks for pointing out to your repo, if you feel you can make a PR to fix this issue we appreciate it as our user base are using this version of the extension right now.

Fahme avatar Oct 22 '21 14:10 Fahme

@Fahme I can create a PR if you want, but it would nearly be a complete rewrite vs. what's currently in this repo - what I've made depends on some different code patterns and helpers that are used throughout the notion-enhancer for performant/accurate modding.

In a month or so the notion-enhancer extension will go up on the chrome store so RTL can be used through there (I've chatted with @obahareth about this and he's happy with it).

dragonwocky avatar Oct 23 '21 00:10 dragonwocky

FYI the notion-enhancer is now available on the Firefox Add-on store and the Chrome Webstore: https://notion-enhancer.github.io/getting-started/installation

dragonwocky avatar Dec 31 '21 11:12 dragonwocky