node-oauth2-server icon indicating copy to clipboard operation
node-oauth2-server copied to clipboard

Remove Bluebird Dependency

Open jwerre opened this issue 3 years ago • 3 comments

We should be able to remove Bluebird as a dependency in favor of standard ES6 Promises.

jwerre avatar Jul 14 '21 21:07 jwerre

It may be worth considering adding a feature where you could plug in your own Promise library (https://github.com/oauthjs/node-oauth2-server/issues/621#issuecomment-880112523). Since Bluebird has been such an integral part of this project many legacy applications may be depending on the extended Promise functionality that it offers. It would be much easier to plug in Bluebird in many cases that to rewrite all that code. Furthermore, if you're using a feature like Cancelations you might find yourself is a situation where upgrading is untenable. One module that did this well is Mongoosehere's what that looks like.

jwerre avatar Jul 16 '21 16:07 jwerre

Is this feature done?

duyleomessi avatar Aug 06 '21 10:08 duyleomessi

Doesn't look like it: https://github.com/oauthjs/node-oauth2-server/blob/015416563fcd5f0dd58e562aabd1b117d4bfa361/lib/response-types/token-response-type.js#L9

jwerre avatar Aug 06 '21 14:08 jwerre