node-oauth2-server icon indicating copy to clipboard operation
node-oauth2-server copied to clipboard

Implement validateRedirectUri model function

Open TheNoim opened this issue 6 years ago • 8 comments

Why should we not be able to verify our uris by ourself. // TODO: Add to docs

TheNoim avatar Mar 25 '18 12:03 TheNoim

Hi, to get this merged we'd need some tests & docs please

thomseddon avatar Aug 03 '18 09:08 thomseddon

@TheNoim Can you describe your use case for this? I'm not quite sure why it's necessary...

mjsalinger avatar Aug 07 '18 12:08 mjsalinger

I can not remember my exact use case or in which project I wanted to use this but a basic use case would be one of this:

  • Custom uri support
  • wildcard support if wanted
  • own validation rules

TheNoim avatar Aug 19 '18 12:08 TheNoim

+1

redirect_uri doesn't have to be exactly equal to any of the redirectUris. Conditions listed below are acceptable on some occasions.

  • same origin and same pathname but different query
  • same origin but different pathname
  • same domain but different protocol
  • same top level domain

geekdada avatar Nov 29 '18 02:11 geekdada

Passing context to all methods also will do the trick.

There are quite a lot of issues depend on this feature:

#536 #336 #150

geekdada avatar Nov 29 '18 02:11 geekdada

Any update for this pull request?

whlsxl avatar Jan 15 '21 09:01 whlsxl

https://github.com/oauthjs/node-oauth2-server/issues/229

whlsxl avatar Jan 15 '21 10:01 whlsxl

Push, we realy need wildcard redirect uris

NilsBaumgartner1994 avatar Nov 09 '21 20:11 NilsBaumgartner1994