express-oauth-server

express-oauth-server copied to clipboard

Change handleError to throw or call next if not OAuthError

1

If the error encountered is not expected (ie. not an OAuth Library error) it should re throw the error (or at least pass it to next to be dealt with)...

chainlink

handleResponse in ExpressOAuthServer.prototype.authorize

5

The execution of `handleResponse` in the `.oauth.authorize` promise chain (https://github.com/oauthjs/express-oauth-server/blob/master/index.js#L78-L80) appears to prematurely terminate the authorization middleware by returning the server response before subsequent operations can take place. When I...

holt

I am using Ubuntu 14.04 and this is the output I get when trying to install from npm: root@9fe82eedfaf2:/# npm install oauth2-server npm http GET https://registry.npmjs.org/oauth2-server npm http 304 https://registry.npmjs.org/oauth2-server...

CameronGo

Issues with 401 handling

1

authenticate always seems to call next() - even though it sets the response status to 401. Is this on purpose?

djMax

`node-oauth2-server` offers an `options`-parameter to its Response constructor. I think `express-oauth-server` should pass (some) of the properties of the express response object via the `options` parameter, so that they are...

steffansluis