Redis dependency is unconditionally activated in 8.x when aliasing Helm chart

[dchandekstark]

At least when aliasing the oauth2-proxy 8.x Helm chart for multiple instances, it consistently installs the Redis dependency, even if redis: false is set explicitly on each dependency.

This does not happen when using the chart for a single deployment.

Downgrading to 7.x alleviates the issue, but perhaps a regression was introduced in the process of removing the Bitnami dependency?

[pierluigilenoci]

This is related to #347

[BacLuc]

I had the same issue.

[BacLuc]

Seems we have to wait for helm v4. fix:

• https://github.com/helm/helm/pull/9184

backport:

• https://github.com/helm/helm/pull/30802

[pierluigilenoci]

@dchandekstark, can you please test this with Helm v4?

[BacLuc]

I tested it with helm4, works now.

[pierluigilenoci]

@dchandekstark, can we close the ticket now?

[tuunit]

@dchandekstark

Downgrading to 7.x alleviates the issue, but perhaps a regression was introduced in the process of removing the Bitnami dependency?

This will most likely be due to the fact that the newly introduced dependency is called redis-ha and we added an alias named "redis". Helm v3 doesn't seem to able to deal with aliases properly

[tuunit]

https://github.com/oauth2-proxy/manifests/blob/ef5126e1052264106d58fce4c35e6ee0ff6fd67e/helm/oauth2-proxy/Chart.yaml#L15-L20

Removing the alias and using redis-ha.enabled as a condition would probably fix it

[BacLuc]

Here a commit to use helm v4 in a github action: https://github.com/ecamp/ecamp3/commit/86591aaa04af62dff7c0dd1f40148238d308afd1