oasis-web3-gateway icon indicating copy to clipboard operation
oasis-web3-gateway copied to clipboard

feat: build oasis-node and oasis-net-runner from source

Open CedarMist opened this issue 1 year ago • 2 comments

@abukosek if you're interested, this change builds oasis-core from source rather than pulling from github releases

I think we should have the option to build Sapphire paratime binary from source too as it will make testing changes quicker.

However, I think there should probably be two modes:

  • release mode - uses files downloaded from github releases
  • dev mode - builds everything from source

Will investigate if this is possible.

CedarMist avatar Nov 30 '23 10:11 CedarMist

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.86%. Comparing base (aa3c5a1) to head (588503f). Report is 182 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          37       37           
  Lines        3920     3920           
=======================================
  Hits         2425     2425           
  Misses       1288     1288           
  Partials      207      207           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 11:11 codecov[bot]

Cool! Yeah, I also think there should be two separate modes for this. The simplest way to do this would be to add another ENV var and then conditionally build from source or download existing artifacts based on that (or even better, an ARG, which we could then specify when building the image with --build-arg).

abukosek avatar Nov 30 '23 11:11 abukosek

Superseeded by https://github.com/oasisprotocol/oasis-web3-gateway/pull/601

matevz avatar Sep 11 '24 10:09 matevz