oasis-wallet-web
oasis-wallet-web copied to clipboard
ParaTimes: handle MAX value in transaction amount step
- set max amount based on transaction type and/or custom fee
- extend form validation to include a case where user uses max button and later changes fee amount
π¦ MegaLinter status: β SUCCESS
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
β EDITORCONFIG | editorconfig-checker | 7 | 0 | 0.05s | |
β JSON | eslint-plugin-jsonc | 1 | 0 | 0 | 1.16s |
β JSON | jsonlint | 1 | 0 | 0.28s | |
β JSON | prettier | 1 | 0 | 0 | 0.75s |
β JSON | v8r | 1 | 0 | 1.98s | |
β REPOSITORY | checkov | yes | no | 18.0s | |
β REPOSITORY | git_diff | yes | no | 0.01s | |
β TSX | eslint | 2 | 0 | 0 | 6.79s |
β TYPESCRIPT | eslint | 3 | 0 | 0 | 6.9s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff
Codecov Report
Merging #988 (2df0953) into master (dc61073) will decrease coverage by
1.77%
. The diff coverage is95.23%
.
:exclamation: Current head 2df0953 differs from pull request most recent head 6fe0754. Consider uploading reports for the commit 6fe0754 to get more accurate results
@@ Coverage Diff @@
## master #988 +/- ##
==========================================
- Coverage 85.59% 83.82% -1.78%
==========================================
Files 140 121 -19
Lines 2638 2256 -382
Branches 648 544 -104
==========================================
- Hits 2258 1891 -367
+ Misses 380 365 -15
Flag | Coverage Ξ | |
---|---|---|
cypress | 51.64% <4.76%> (-4.84%) |
:arrow_down: |
jest | 77.04% <95.23%> (+2.83%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
src/app/lib/helpers.ts | 72.88% <ΓΈ> (+2.38%) |
:arrow_up: |
src/app/pages/ParaTimesPage/useParaTimes.ts | 92.10% <ΓΈ> (ΓΈ) |
|
...pp/pages/ParaTimesPage/TransactionAmount/index.tsx | 95.00% <95.00%> (+1.45%) |
:arrow_up: |
src/app/lib/transaction.ts | 67.05% <100.00%> (ΓΈ) |
|
.../ParaTimesPage/ParaTimesPageInaccessible/index.tsx | 33.33% <0.00%> (-66.67%) |
:arrow_down: |
src/app/pages/ParaTimesPage/index.tsx | 6.45% <0.00%> (-48.39%) |
:arrow_down: |
src/types/errors.ts | 50.00% <0.00%> (-16.67%) |
:arrow_down: |
...es/ParaTimesPage/TransactionAmount/FeesSection.tsx | 83.33% <0.00%> (-16.67%) |
:arrow_down: |
src/app/lib/eth-helpers.ts | 30.76% <0.00%> (-15.39%) |
:arrow_down: |
...pages/ParaTimesPage/TransactionRecipient/index.tsx | 76.92% <0.00%> (-15.39%) |
:arrow_down: |
... and 52 more |
will restore ParaTime work in new PRs