oasis-wallet-web icon indicating copy to clipboard operation
oasis-wallet-web copied to clipboard

fix(deps): update dependency @ledgerhq/hw-transport-webusb to v6.27.2

Open renovate[bot] opened this issue 2 years ago β€’ 2 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ledgerhq/hw-transport-webusb (source) 6.20.0 -> 6.27.2 age adoption passing confidence

Release Notes

LedgerHQ/ledger-live

v6.27.2

Compare Source

v6.27.1

Compare Source

v6.24.1

Compare Source


Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Jul 01 '22 08:07 renovate[bot]

MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… EDITORCONFIG editorconfig-checker 2 0 0.01s
βœ… GIT git_diff yes no 0.02s
βœ… JSON eslint-plugin-jsonc 1 0 0 1.07s
βœ… JSON jsonlint 1 0 0.29s
βœ… JSON prettier 1 0 0 0.65s
βœ… JSON v8r 1 0 4.96s

See errors details in artifact MegaLinter reports on CI Job page Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

github-actions[bot] avatar Jul 01 '22 08:07 github-actions[bot]

Error: src/app/state/ledger/saga.ts(40,5): error TS2322: Type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport-webusb/node_modules/@ledgerhq/hw-transport/lib/Transport").default' is not assignable to type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/lib/Transport").default'. Types of property 'deviceModel' are incompatible. Type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/devices/lib/index").DeviceModel | null | undefined' is not assignable to type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/node_modules/@ledgerhq/devices/lib/index").DeviceModel | null | undefined'. Type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/devices/lib/index").DeviceModel' is not assignable to type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/node_modules/@ledgerhq/devices/lib/index").DeviceModel'. Types of property 'id' are incompatible. Type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/devices/lib/index").DeviceModelId' is not assignable to type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/node_modules/@ledgerhq/devices/lib/index").DeviceModelId'. Property 'nanoFTS' is missing in type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/node_modules/@ledgerhq/devices/lib/index").DeviceModelId'. Error: src/app/state/ledger/saga.ts(43,34): error TS2769: No overload matches this call. The last overload gave the following error. Argument of type '(transport: Transport, count?: number) => Promise<LedgerAccount[]>' is not assignable to parameter of type '{ context: unknown; fn: (this: unknown, ...args: any[]) => any; }'. Error: src/app/state/ledger/saga.ts(82,23): error TS2345: Argument of type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport-webusb/node_modules/@ledgerhq/hw-transport/lib/Transport").default' is not assignable to parameter of type 'import("/home/runner/work/oasis-wallet-web/oasis-wallet-web/node_modules/@ledgerhq/hw-transport/lib/Transport").default'. error Command failed with exit code 2.

alright this would bring us into dependency hell

pro-wh avatar Aug 23 '22 00:08 pro-wh

Codecov Report

Merging #899 (c375388) into master (5bfbe1e) will increase coverage by 9.76%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   78.79%   88.55%   +9.76%     
==========================================
  Files         100      101       +1     
  Lines        1745     1748       +3     
  Branches      403      403              
==========================================
+ Hits         1375     1548     +173     
+ Misses        370      200     -170     
Flag Coverage Ξ”
cypress 60.64% <ΓΈ> (?)
jest 78.79% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/index.tsx 100.00% <0.00%> (ΓΈ)
src/app/pages/AccountPage/index.tsx 96.29% <0.00%> (+1.85%) :arrow_up:
src/app/state/staking/saga.ts 85.36% <0.00%> (+2.43%) :arrow_up:
src/app/components/MnemonicValidation/index.tsx 100.00% <0.00%> (+5.26%) :arrow_up:
src/app/lib/key.ts 93.75% <0.00%> (+6.25%) :arrow_up:
...ages/AccountPage/Features/AccountSummary/index.tsx 100.00% <0.00%> (+6.45%) :arrow_up:
...ge/Features/ImportAccountsSelectionModal/index.tsx 96.55% <0.00%> (+6.89%) :arrow_up:
src/app/components/Toolbar/index.tsx 100.00% <0.00%> (+7.14%) :arrow_up:
...ges/AccountPage/Features/SendTransaction/index.tsx 92.59% <0.00%> (+7.40%) :arrow_up:
src/app/state/wallet/saga.ts 98.33% <0.00%> (+8.33%) :arrow_up:
... and 19 more

codecov[bot] avatar Sep 27 '22 13:09 codecov[bot]

  • Parcel does not support subpath exports so we need an alias to fix build task
  • added @ledgerhq/hw-transport to resolutions. We are importing Transport type from @ledgerhq/hw-transport https://github.com/oasisprotocol/oasis-wallet-web/pull/620/commits/d4564464c713a2fa305a4f0fccdd9d5e500583bc but we don't control that package directly. It's dep of hw-transport-webusb and @oasisprotocol/ledger and we need to force usage of newer version.

buberdds avatar Sep 27 '22 13:09 buberdds