feature: Add ADR 0008 option for opening Ledger wallet
Fixes #760
Merge after https://github.com/oasisprotocol/oasis-wallet-web/issues/792 is implemented and show ADR8 option only when the user enables some "advanced" mode.
| before | after |
|---|---|
![]() |
![]() |
Depends on Ledger docs update https://github.com/oasisprotocol/docs/pull/57
MegaLinter status: ✅ SUCCESS
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ EDITORCONFIG | editorconfig-checker | 16 | 0 | 0.77s | |
| ✅ GIT | git_diff | yes | no | 0.04s | |
| ✅ JSON | eslint-plugin-jsonc | 3 | 0 | 0 | 0.98s |
| ✅ JSON | jsonlint | 3 | 0 | 0.75s | |
| ✅ JSON | prettier | 3 | 0 | 0 | 0.67s |
| ✅ JSON | v8r | 3 | 0 | 2.56s | |
| ✅ TSX | eslint | 2 | 0 | 0 | 6.06s |
| ✅ TYPESCRIPT | eslint | 9 | 0 | 0 | 4.41s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
you need to bump snapshots and a few saga tests are failing
Codecov Report
Merging #761 (fdca15d) into master (316d9b7) will decrease coverage by
0.35%. The diff coverage is67.74%.
:exclamation: Current head fdca15d differs from pull request most recent head 9f3bb9c. Consider uploading reports for the commit 9f3bb9c to get more accurate results
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 88.24% 87.88% -0.36%
==========================================
Files 100 100
Lines 1693 1717 +24
Branches 338 341 +3
==========================================
+ Hits 1494 1509 +15
- Misses 199 208 +9
| Flag | Coverage Δ | |
|---|---|---|
| cypress | 57.29% <16.12%> (-0.60%) |
:arrow_down: |
| jest | 74.72% <67.74%> (-0.18%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/app/state/ledger/index.ts | 50.00% <0.00%> (-10.87%) |
:arrow_down: |
| src/types/errors.ts | 100.00% <ø> (ø) |
|
| ...pages/OpenWalletPage/Features/FromLedger/index.tsx | 69.56% <75.00%> (-0.44%) |
:arrow_down: |
| src/app/state/ledger/saga.ts | 97.82% <75.00%> (-2.18%) |
:arrow_down: |
| src/app/lib/ledger.ts | 97.95% <90.90%> (-2.05%) |
:arrow_down: |
| ...ponents/Toolbar/Features/AccountSelector/index.tsx | 100.00% <100.00%> (ø) |
|
| src/app/state/ledger/selectors.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a29bd1a...9f3bb9c. Read the comment docs.
Task linked: CU-2gf4peq Add support to Oasis Wallet - Web

