oasis-wallet-web icon indicating copy to clipboard operation
oasis-wallet-web copied to clipboard

Fix physical back button behavior on Android

Open lubej opened this issue 9 months ago • 4 comments

Solution

Current behavior of physical back button on Android is unexpected. Back button was closing the app, which is not the expected behavior. This correctly integrates with react-router-dom to navigate one page in history back and only closes the app, if there is no history.

Resources

https://github.com/oasisprotocol/oasis-wallet-web/assets/9722540/448d4168-03c1-4a1f-944d-e19d03e669e7

lubej avatar May 09 '24 12:05 lubej

Deployed to Cloudflare Pages

Latest commit: 84e063694ea9de7aacf993bc5f1a6e635b7908d8
Status:✅ Deploy successful!
Preview URL: https://3c9fd0be.oasis-wallet.pages.dev

github-actions[bot] avatar May 09 '24 12:05 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 4.21 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.94 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 12.5 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 80 kB nicolo-ribaudo
npm/@capacitor/[email protected] None 0 66.4 kB ionicjs
npm/[email protected] None 0 25.4 kB ljharb
npm/[email protected] None +1 31.9 kB ljharb
npm/[email protected] filesystem Transitive: environment, unsafe +5 558 kB d-fischer
npm/[email protected] None +1 48.3 kB matteo.collina
npm/[email protected] eval +1 50.7 kB ljharb
npm/[email protected] None 0 41.7 kB indutny
npm/[email protected] None 0 28.8 kB ljharb
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 12.7 kB ljharb
npm/[email protected] None 0 12.3 kB ljharb
npm/[email protected] None 0 2.97 kB thejameskyle
npm/[email protected] None 0 34.9 kB isaacs
npm/[email protected] None 0 15.6 kB ljharb
npm/[email protected] None 0 30.9 kB ljharb
npm/[email protected] None +1 15.8 kB sindresorhus
npm/[email protected] None 0 39 kB ljharb
npm/[email protected] None +2 578 kB awaterma
npm/[email protected] None 0 34.7 kB ljharb

🚮 Removed packages: npm/@protobufjs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar May 10 '24 03:05 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar May 10 '24 03:05 socket-security[bot]

FYI: Tried with https://ionic-docs-5utg8ms4c-ionic1.vercel.app/docs/v5/developing/hardware-back-button but didn't seem to work for some reason.

lubej avatar May 10 '24 03:05 lubej