oasis-wallet-web icon indicating copy to clipboard operation
oasis-wallet-web copied to clipboard

Update mobile brand assets

Open buberdds opened this issue 9 months ago • 7 comments

https://app.clickup.com/t/8694cukt5

  • adaptive icon sample

Screenshot from 2024-05-09 11-09-49 Screenshot from 2024-05-09 11-09-39

buberdds avatar May 09 '24 09:05 buberdds

Deployed to Cloudflare Pages

Latest commit: 5379756f52367bec5a59c535fe23221547fc31a3
Status:✅ Deploy successful!
Preview URL: https://ed66eabb.oasis-wallet.pages.dev

github-actions[bot] avatar May 09 '24 09:05 github-actions[bot]

The new design does look way cooler, gg @buberdds on suggesting it 👍

lubej avatar May 09 '24 16:05 lubej

Can we commit the changes for resources folder? The folder that assets get generated from. So it's easy to reproduce the current results. + did you minify the original icon/splash?

  1. lol I did not even notice this folder. Why it's not called assets like in Capacitor docs?
  2. I did not minify source files, only generated ones.
  3. hm I don't like idea of adding 9MB of source image files to the repo. These files are controlled and prepared by designers not us

buberdds avatar May 10 '24 07:05 buberdds

  1. lol I did not even notice this folder. Why it's not called assets like in Capacitor docs?

It does support both folders. https://github.com/ionic-team/capacitor-assets#usage. But I think resources was legacy I guess, because before it was community package(from what I remember).

  1. I did not minify source files, only generated ones.

Wait, you went through the trouble to minify every generated one? The last time I did it, I just minified the ones in resources folder.

  1. hm I don't like idea of adding 9MB of source image files to the repo. These files are controlled and prepared by designers not us

But if we nuke android/ios due to an upgrade, or something changes in the structure(like new device aspect ration in any of the platforms). It would be easier, for consistent asset generation. I would just minify them first.

lubej avatar May 10 '24 09:05 lubej

Wait, you went through the trouble to minify every generated one? The last time I did it, I just minified the ones in resources folder.

if the trouble is to run one CLI command than yes. Maybe that's why most of prev assets were much larger

But if we nuke android/ios due to an upgrade, or something changes in the structure(like new device aspect ration in any of the platforms). It would be easier, for consistent asset generation. I would just minify them first.

For image manipulation like scaling I guess it's better to use original source file not minified, but Ok I will add assets folder.

buberdds avatar May 10 '24 09:05 buberdds

if the trouble is to run one CLI command than yes. Maybe that's why most of prev assets were much larger

Yes, true, that way it is really simple. Didn't think of that 😅

For image manipulation like scaling I guess it's better to use original source file not minified, but Ok I will add assets folder.

True, but it is usually scaled down from the original image anyway. Don't think there is an image larger than the source file. But anyhow, I agree your way is better 👍 I personally would appreciate if the source files are added to the repo.If you strongly disagree we can leave them out.

lubej avatar May 10 '24 10:05 lubej

hm cannot merge due to stuck Post Run satackey/[email protected]

buberdds avatar May 10 '24 11:05 buberdds

manually wiped out github caches (100+) for this PR as we were running out of avail cache space. will create issue to remove satackey/action-docker-layer-caching as it is deprecated

buberdds avatar May 13 '24 06:05 buberdds