oasis-wallet-web icon indicating copy to clipboard operation
oasis-wallet-web copied to clipboard

Refactor HomePage buttons into ButtonLinks to improve accessibility

Open lukaw3d opened this issue 3 years ago • 2 comments

Fixes issues:

  • Keyboard navigating through these buttons would first focus on the link, and then on the button
  • Multiple buttons were marked as type="submit" without being in multiple forms
  • On a small screen "Mnemonic / Private key / Ledger" buttons would collapse into rows of left-aligned buttons, but links would fill up the whole row

lukaw3d avatar Oct 21 '22 02:10 lukaw3d

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 7 0 0.02s
✅ REPOSITORY checkov yes no 12.91s
✅ REPOSITORY git_diff yes no 0.0s
✅ TSX eslint 3 0 0 6.51s
✅ TYPESCRIPT eslint 4 0 0 6.16s

See errors details in artifact MegaLinter reports on CI Job page Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

github-actions[bot] avatar Oct 21 '22 02:10 github-actions[bot]

findByRole('link') in cypress tests

buberdds avatar Oct 21 '22 08:10 buberdds

Codecov Report

Merging #1097 (df65e68) into master (9b0813c) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head df65e68 differs from pull request most recent head 79bf913. Consider uploading reports for the commit 79bf913 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   88.75%   88.77%   +0.01%     
==========================================
  Files         102      103       +1     
  Lines        1778     1781       +3     
  Branches      411      411              
==========================================
+ Hits         1578     1581       +3     
  Misses        200      200              
Flag Coverage Δ
cypress 60.64% <100.00%> (+0.06%) :arrow_up:
jest 78.78% <33.33%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/HomePage/index.tsx 100.00% <ø> (ø)
src/app/pages/OpenWalletPage/index.tsx 100.00% <ø> (ø)
src/app/components/ButtonLink/index.tsx 100.00% <100.00%> (ø)

codecov[bot] avatar Oct 21 '22 18:10 codecov[bot]