oasis-wallet-web icon indicating copy to clipboard operation
oasis-wallet-web copied to clipboard

Update TransactionPreview modal

Open buberdds opened this issue 2 years ago β€’ 1 comments

Minor updates to transaction preview to make it more readable in extension

  • split content into sections: to/from, amounts, hash
  • modal title takes responsibility of "type row"
  • hash takes 100% width

current ext Screenshot 2022-09-26 at 15 41 42

updated Screenshot 2022-09-26 at 15 52 30

buberdds avatar Sep 26 '22 14:09 buberdds

πŸ¦™ MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… EDITORCONFIG editorconfig-checker 6 0 0.02s
βœ… JSON eslint-plugin-jsonc 1 0 0 1.46s
βœ… JSON jsonlint 1 0 0.31s
βœ… JSON prettier 1 0 0 0.74s
βœ… JSON v8r 1 0 2.44s
βœ… REPOSITORY checkov yes no 17.15s
βœ… REPOSITORY git_diff yes no 0.0s
βœ… TSX eslint 4 0 0 6.58s

See errors details in artifact MegaLinter reports on CI Job page Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

github-actions[bot] avatar Sep 26 '22 14:09 github-actions[bot]

Codecov Report

Merging #1029 (26bad14) into master (c32d951) will decrease coverage by 0.03%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   83.68%   83.64%   -0.04%     
==========================================
  Files         121      120       -1     
  Lines        2249     2250       +1     
  Branches      539      544       +5     
==========================================
  Hits         1882     1882              
- Misses        367      368       +1     
Flag Coverage Ξ”
cypress 51.78% <90.00%> (-0.03%) :arrow_down:
jest 76.89% <30.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/app/components/TransactionPreview/index.tsx 81.25% <75.00%> (-2.09%) :arrow_down:
src/app/components/ResponsiveGridRow/index.tsx 100.00% <100.00%> (ΓΈ)
src/app/components/TransactionModal/index.tsx 92.00% <100.00%> (+0.33%) :arrow_up:

codecov[bot] avatar Nov 03 '22 10:11 codecov[bot]