oasis-rosetta-gateway icon indicating copy to clipboard operation
oasis-rosetta-gateway copied to clipboard

account: provide delegations_to instead

Open pro-wh opened this issue 3 years ago • 3 comments

oasis-node does not handle GetDelegations efficiently. This changes the gateway to use GetDelegationsTo, which the node can answer efficiently.


ok and from #61/#62, it seems we didn't specifically want delegations from, and the issue looks like it was written to call for either of them. at this point, we know that the node software can much more easily list delegations to an account and debonding delegations "from" an account, so I'm proposing that we move to those.

for users relying on the previous delegations "from" behavior, you'll have to stay on the 2.x.x stable branches, and we should maintain that for some amount of time.

I intend for us to upgrade any of our own deployments to include this change.

fixes #347

pro-wh avatar May 26 '22 20:05 pro-wh

sad note: one of the gateways we use times out trying to get delegations from, so at least we know that nothing is usefully relying on it :grimacing:

pro-wh avatar May 26 '22 20:05 pro-wh

"delegations to" is not efficient either. converting this to draft

pro-wh avatar Oct 31 '22 21:10 pro-wh

https://github.com/oasisprotocol/oasis-core/pull/5023 with any luck, we'll have efficient DelegationsFor in the same timeframe, so we won't have to merge this change

pro-wh avatar Nov 09 '22 20:11 pro-wh

this is now quite fast in 23.0.x

pro-wh avatar Nov 29 '23 19:11 pro-wh