oasis-core icon indicating copy to clipboard operation
oasis-core copied to clipboard

oasis-test-runner: Enable sgx_loader in client node

Open matevz opened this issue 1 year ago β€’ 4 comments

Needed by https://github.com/oasisprotocol/oasis-web3-gateway/pull/625

matevz avatar Sep 25 '24 14:09 matevz

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
Latest commit ea33628fedd4539165c0bf62ad6a2ccbea91f7c3
Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/66f57ab62a7cf70008173500

netlify[bot] avatar Sep 25 '24 14:09 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.07%. Comparing base (28736a2) to head (e552937). Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5868      +/-   ##
==========================================
+ Coverage   64.93%   65.07%   +0.14%     
==========================================
  Files         622      624       +2     
  Lines       63492    63724     +232     
==========================================
+ Hits        41229    41470     +241     
+ Misses      17379    17369      -10     
- Partials     4884     4885       +1     
Flag Coverage Ξ”
65.07% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 25 '24 14:09 codecov[bot]

Since we won't be running ROFLs on the client nodes on sapphire-localnet yet I think there is no need for this PR anymore.

matevz avatar Oct 08 '24 16:10 matevz

Still makes sense to do it?

kostko avatar Oct 08 '24 16:10 kostko