cti-stix-elevator icon indicating copy to clipboard operation
cti-stix-elevator copied to clipboard

Handle Field-level Markings

Open emmanvg opened this issue 7 years ago • 7 comments

Currently the stix2elevator only supports global and object level markings. There is no support for field level markings. Also, no message is printed to indicate we encountered one.

Related to #13

emmanvg avatar Nov 16 '17 14:11 emmanvg

How big of a priority is this? I agree we should at least print a warning/error message, but actually translating them seems like a difficult task.

gtback avatar Nov 16 '17 14:11 gtback

Maybe have a separate issue for adding the warning - and add it to the milestone

rpiazza avatar Nov 16 '17 14:11 rpiazza

I believe you can mention it your commit message without the need to close or create a new issue. In the commit message include "Added log message for Field-Level Markings. related to (hash-tag)84" (where hash-tag is the actual character). I don't know if adding it to the milestone would be relevant since it is not solving the actual problem.

emmanvg avatar Nov 16 '17 15:11 emmanvg

I agree @gtback, the message should be enough for now. I just created this issue for bookkeeping. Up to now, there has not been a request to support it.

emmanvg avatar Nov 16 '17 15:11 emmanvg

an issue is just something that needs to "get done" :-)

We want to be able to present to Preston a list of the work we intend to do so the elevator is ready for AIS

rpiazza avatar Nov 16 '17 15:11 rpiazza

AIS markings makes use of global markings. Which is already supported by the elevator. Field-Level markings is a general case scenario you may encounter with markings.

emmanvg avatar Nov 16 '17 15:11 emmanvg

The PR that provides the functionality can be added to the milestone.

emmanvg avatar Nov 16 '17 15:11 emmanvg