cti-stix-common-objects icon indicating copy to clipboard operation
cti-stix-common-objects copied to clipboard

malware-behavior $refs URLs point to /malware-behavior/ instead of /malware-behavior-8e9/

Open dunkeki opened this issue 1 year ago • 9 comments

Don't know if these have been fixed by Charles et al, but they're broken in cti-stix-common-objects/extension-definition-specifications/malware-behavior-8e9/ ... thanks!

dunkeki avatar Nov 18 '24 14:11 dunkeki

Part of the problem is that these are absolute URLs - the problem wouldn't be so profound if they were relative refs...

dunkeki avatar Nov 18 '24 14:11 dunkeki

@dunkeki - I made the changes to add 8e9 to the urls that were missing it. It is on the malware-behavior-8e9 branch. Please test it. If it is ok I will merge it in.

rpiazza avatar Nov 18 '24 16:11 rpiazza

Missed one in extension-definition--8e9e338f-c9ee-4d4f-8cac-85b4dcfdf3c1.json, thanks.

dunkeki avatar Nov 18 '24 17:11 dunkeki

Done

rpiazza avatar Nov 18 '24 18:11 rpiazza

Since the $ref URLs are absolute to raw GitHub, I can't test. Things are probably correct (well, the current version is broken so merging what is probably correct is a good thing). Can you please merge? Thanks.

If you know a way around this without merging, let me know...

dunkeki avatar Nov 18 '24 19:11 dunkeki

Those $ref should be relative. Then my local copy (which is corrected by you, thanks) would be used and work :(

dunkeki avatar Nov 18 '24 19:11 dunkeki

If you'd like, I can fix my local copy, get it working (AFAIK), and then post a tarball back to here...

dunkeki avatar Nov 18 '24 19:11 dunkeki

I'm not 100% sure why absolute urls were used, if it was necessary. Let me do the merge, then you can experiment.

rpiazza avatar Nov 18 '24 19:11 rpiazza

malware-behavior-8e9.TGZ

In addition to relativizing the $ref, there were a number of JSON errors in examples/behavior-unprotect.json (e.g. extra commas on a last array element, etc.). That file has been fixed as well (even though it won't pass schema validation - as intended - but the schema still work referencing each other etc.)

Thanks!

dunkeki avatar Nov 18 '24 19:11 dunkeki