cti-python-stix2 icon indicating copy to clipboard operation
cti-python-stix2 copied to clipboard

Published 20 hours ago • verified publisher icon oasis-open

Fix properties types

Open SYNchroACK opened this issue 2 years ago • 2 comments

  • Rename properties types based on the naming pattern
  • Add missing _type field

SYNchroACK avatar Oct 18 '23 21:10 SYNchroACK

@chisholm - is this worth merging?

rpiazza avatar Apr 09 '25 15:04 rpiazza

In principle, I am okay with what the changes are doing. But this doesn't appear to change type names in enough places. For example, see imports in:

https://github.com/oasis-open/cti-python-stix2/blob/6dd83fae9dfa6b3fda9de865801d5796f9d8f7e7/stix2/v21/init.py#L26-L35

This change breaks some of those imports. Perhaps an IDE should be used to do the refactor, to ensure the names are changed in all places they are used.

chisholm avatar Apr 10 '25 02:04 chisholm

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 31 '25 09:07 CLAassistant